Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add option to clean scheduled messages on startup #1352

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kenliao94
Copy link
Contributor

Working in progress: add an option to delete all scheduled message on startup.

@kenliao94
Copy link
Contributor Author

Hey @mattrpav and @jbonofre I am curious on what you think about the approach here and want to clarify a few things:

  1. I was debating between adding this logic to the job scheduler or the persistence layer (following the approach of deleteAllMessages). However, I noticed that SchedulerBroker doesn't expose their internal scheduler, and it has public methods that deal directly with Message (initially I thought SchedulerBroker is not "message aware" but only "job aware". So I decided to add the logic in SB. What do you think?

  2. I wasn't able to find any other non-message jobs (even job in ByteSequence type is assumed to be unmarshal into Message) scheduled on "JMS" scheduler so I assume that remove all jobs are safe. However, do you know any pitfull for simply remove all jobs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant