Fix compilation error. Use new IO API #286
Conversation
| @@ -61,8 +60,7 @@ public Report runTest(final Environment env) throws Exception { | |||
| client.tableOperations().addSplits(TABLE_NAME, getSplits()); | |||
| client.instanceOperations().waitForBalance(); | |||
|
|
|||
| int totalTabletServers = | |||
| client.instanceOperations().getServers(ServerId.Type.TABLET_SERVER).size(); | |||
| int totalTabletServers = client.instanceOperations().getTabletServers().size(); | |||
There was a problem hiding this comment.
This getTabletServers() method is currenty deprecated in main and using it here will cause the build to fail. So we should not be going back to the deprecated code. Not sure why but it seems the gh actions build is using an older version of accumulo 4.0-snap.
Locally when I do the following the accumulo-testing build will fail.
git checkout main
git pull
mvn clean install -PskipQA
cd ../accumulo-testing/
git checkout fixBuild
mvn clean package -DskipTests
Will see the following errors.
[INFO] --- compiler:3.11.0:compile (default-compile) @ accumulo-testing ---
[INFO] Changes detected - recompiling the module! :source
[INFO] Compiling 207 source files with javac [debug deprecation release 11] to target/classes
[INFO] -------------------------------------------------------------
[WARNING] COMPILATION WARNING :
[INFO] -------------------------------------------------------------
[WARNING] accumulo-testing/src/main/java/org/apache/accumulo/testing/randomwalk/bulk/SelectiveQueueing.java:[40,50] getTabletServers() in org.apache.accumulo.core.client.admin.InstanceOperations has been deprecated
[WARNING]accumulo-testing/src/main/java/org/apache/accumulo/testing/performance/tests/SplitBalancingPT.java:[63,57] getTabletServers() in org.apache.accumulo.core.client.admin.InstanceOperations has been deprecated
[INFO] 2 warnings
[INFO] -------------------------------------------------------------
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] accumulo-testing/src/main/java/org/apache/accumulo/testing/randomwalk/bulk/SelectiveQueueing.java: warnings found and -Werror specified
[INFO] 1 error
There was a problem hiding this comment.
That is a recent commit on main where the method is deprecated.
There was a problem hiding this comment.
Asked about this on slack
Seems the apache jenkins sever has not built accumulo 4.0.0-snapshot and that is causing the mismatch between the latest commit in accumulo/main and the github build.
There was a problem hiding this comment.
Ran the build on apache jenkins server and produiced a new accumulo 4.0.0-snapshot jar. Now the latest code is available to accumulo-testing and its building now.
There was a problem hiding this comment.
Looks like the build is passing in the accumulo-testing elasticity branch. So maybe this PR should be closed.
There was a problem hiding this comment.
Yeah should probably close this. Sorry for the trouble, looking at the cause of this problem I should not have merged #284 since the GH build was failing on that PR
The build was failing with the following: