Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix: rename DnD types to match component names in Superset #988

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

kgabryje
Copy link
Contributor

@kgabryje kgabryje commented Mar 3, 2021

Rename dndGroupByControl type from DndColumnSelectControl to DndColumnSelect so that it matches component name in Superset after refactor (apache/superset#13340)
.

@kgabryje kgabryje requested a review from a team as a code owner March 3, 2021 15:32
@vercel
Copy link

vercel bot commented Mar 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/C5xpmSypxxXuRH8GTSeyLN3J3LQd
✅ Preview: https://superset-ui-git-fork-kgabryje-fix-dnd-rename-superset.vercel.app

@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #988 (973f708) into master (0b48c32) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #988   +/-   ##
=======================================
  Coverage   28.10%   28.10%           
=======================================
  Files         412      412           
  Lines        8411     8411           
  Branches     1193     1193           
=======================================
  Hits         2364     2364           
  Misses       5894     5894           
  Partials      153      153           
Impacted Files Coverage Δ
...chart-controls/src/shared-controls/dndControls.tsx 35.29% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b48c32...973f708. Read the comment docs.

@villebro villebro merged commit 15a718a into apache-superset:master Mar 4, 2021
NejcZdovc pushed a commit to blotoutio/superset-ui that referenced this pull request Apr 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants