Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix(plugin-chart-echarts): fix incorrect groupby in buildQuery #800

Merged

Conversation

villebro
Copy link
Contributor

🐛 Bug Fix
Fix a regression caused by party contradictory naming in controls/buildQuery.

@villebro villebro requested a review from a team as a code owner September 29, 2020 05:51
@vercel vercel bot temporarily deployed to Preview September 29, 2020 05:51 Inactive
@vercel
Copy link

vercel bot commented Sep 29, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/69k3diday
✅ Preview: https://superset-ui-git-fork-preset-io-villebro-fix-echarts-groupby.superset.vercel.app

@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #800 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #800      +/-   ##
==========================================
- Coverage   25.35%   25.34%   -0.01%     
==========================================
  Files         354      354              
  Lines        7881     7882       +1     
  Branches     1035     1036       +1     
==========================================
  Hits         1998     1998              
  Misses       5774     5774              
- Partials      109      110       +1     
Impacted Files Coverage Δ
.../plugin-chart-echarts/src/Timeseries/buildQuery.ts 42.85% <0.00%> (-7.15%) ⬇️
...lugin-chart-echarts/src/Timeseries/controlPanel.ts 100.00% <ø> (ø)
...ugins/legacy-plugin-chart-sankey-loop/src/index.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0b6fa0...ee9b134. Read the comment docs.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@villebro villebro force-pushed the villebro/fix-echarts-groupby branch from efe4a01 to ee9b134 Compare September 29, 2020 07:30
@villebro villebro merged commit 166b95b into apache-superset:master Sep 29, 2020
@villebro villebro deleted the villebro/fix-echarts-groupby branch September 29, 2020 07:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants