Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

chore: move @types/react to peerDependencies #774

Merged
merged 2 commits into from
Sep 8, 2020

Conversation

ktmud
Copy link
Contributor

@ktmud ktmud commented Sep 8, 2020

🏠 Internal

move @types/react to peerDependencies otherwise npm link will install @types/react in both ``superset-frontend/node_modules/@types/reactandsuperset-frontned/@node_modules/@superset-ui/xxxx/node_modules/@types/react`. TSC (`npm run dev-server`) may throw errors with duplicate `@types/react` installations.

@vercel
Copy link

vercel bot commented Sep 8, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/qsl94y4x7
✅ Preview: https://superset-ui-git-fork-ktmud-types-react-peerdependencies.superset.vercel.app

@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #774 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #774   +/-   ##
=======================================
  Coverage   24.90%   24.90%           
=======================================
  Files         353      353           
  Lines        7839     7839           
  Branches     1003     1003           
=======================================
  Hits         1952     1952           
  Misses       5785     5785           
  Partials      102      102           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0205285...3d39fb8. Read the comment docs.

@pull-request-size pull-request-size bot removed the size/S label Sep 8, 2020
@ktmud ktmud merged commit c143dfd into apache-superset:master Sep 8, 2020
@ktmud ktmud deleted the types-react-peerDependencies branch September 8, 2020 20:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants