Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat(color): add official ECharts color schemes #751

Merged
merged 2 commits into from
Aug 26, 2020

Conversation

villebro
Copy link
Contributor

@villebro villebro commented Aug 25, 2020

@villebro villebro requested a review from a team as a code owner August 25, 2020 10:01
@vercel
Copy link

vercel bot commented Aug 25, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/l84hz35b4
✅ Preview: https://superset-ui-git-fork-preset-io-villebro-echarts-colors.superset.vercel.app

@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #751 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #751      +/-   ##
==========================================
+ Coverage   24.43%   24.45%   +0.01%     
==========================================
  Files         334      335       +1     
  Lines        7652     7654       +2     
  Branches      937      937              
==========================================
+ Hits         1870     1872       +2     
  Misses       5708     5708              
  Partials       74       74              
Impacted Files Coverage Δ
...set-ui-color/src/colorSchemes/sequential/common.ts 100.00% <ø> (ø)
...t-ui-color/src/colorSchemes/categorical/echarts.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f090ff...5aa3a8f. Read the comment docs.

@kristw
Copy link
Contributor

kristw commented Aug 25, 2020

I am confused. Why are they called "ECharts 4 colors" and "ECharts 5 colors" when there are more than 4 and 5 colors?

@villebro
Copy link
Contributor Author

@kristw it's for version 4.x vs version 5.x. I'll update to make it more clear.

Copy link
Contributor

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants