This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 273
refactor: move translation, connection, query to core #729
Merged
ktmud
merged 9 commits into
apache-superset:monopackage
from
ktmud:monopackage-move-connection
Aug 11, 2020
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2d448b7
refactor: move translation, connection, query to core
ktmud 763412a
Optimize build script
ktmud 54a9957
Materialize nimbus configs
ktmud 6a38b2b
Optimize build script
ktmud 8002ef0
Update bad imports
ktmud 3d42849
Update doc
ktmud 789855a
Update docs
ktmud 18b05b1
Build esm modules
ktmud 1e17edb
Update logging
ktmud File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
coverage/ | ||
node_modules/ | ||
public/ | ||
esm/ | ||
lib/ | ||
tmp/ | ||
dist/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
const path = require('path'); | ||
|
||
module.exports = { | ||
extends: [ | ||
'./node_modules/@airbnb/config-eslint/lib/presets/base.js', | ||
'./node_modules/@airbnb/config-eslint/lib/presets/next.js', | ||
'./node_modules/@airbnb/config-eslint/lib/presets/typescript.js', | ||
'./node_modules/@airbnb/config-eslint/lib/presets/prettier.js', | ||
'prettier/@typescript-eslint', | ||
'prettier/unicorn', | ||
], | ||
parserOptions: { | ||
project: path.join(__dirname, './tsconfig.eslint.json'), | ||
}, | ||
rules: { | ||
'arrow-parens': ['warn', 'as-needed'], | ||
}, | ||
overrides: [ | ||
{ | ||
files: '**/*.d.ts', | ||
rules: { | ||
'max-classes-per-file': 0, | ||
}, | ||
}, | ||
{ | ||
files: './packages/generator-superset/**/*.test.{js,jsx,ts,tsx}', | ||
rules: { | ||
'jest/expect-expect': 0, | ||
}, | ||
}, | ||
{ | ||
files: '**/test/**/*', | ||
rules: { | ||
'import/no-extraneous-dependencies': 0, | ||
'promise/param-names': 0, | ||
'jest/require-to-throw-message': 0, | ||
'jest/no-test-return-statement': 0, | ||
'jest/no-expect-resolves': 0, | ||
'@typescript-eslint/no-require-imports': 0, | ||
'global-require': 0, | ||
}, | ||
}, | ||
{ | ||
files: '*.{js,jsx,ts,tsx}', | ||
rules: { | ||
'import/extensions': 0, | ||
'no-plusplus': 0, | ||
'react/jsx-no-literals': 0, | ||
'@typescript-eslint/no-unsafe-member-access': 0, | ||
'@typescript-eslint/no-unsafe-call': 0, | ||
'@typescript-eslint/no-explicit-any': [ | ||
'warn', | ||
{ | ||
fixToUnknown: false, | ||
}, | ||
], | ||
}, | ||
}, | ||
{ | ||
files: ['./scripts/*', './*.config.js'], | ||
rules: { | ||
'no-console': 0, | ||
}, | ||
env: { | ||
node: true, | ||
}, | ||
}, | ||
], | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"paths": ["{packages,plugins}/*/{src,test,types}/**/*.{ts,tsx,js,jsx}"], | ||
"ignores": ["**/node_modules/**/*"], | ||
"port": 5004 | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
coverage/ | ||
node_modules/ | ||
public/ | ||
esm/ | ||
lib/ | ||
tmp/ | ||
dist/ | ||
lerna.json | ||
npm-shrinkwrap.json | ||
package.json | ||
package-lock.json | ||
tsconfig.json | ||
tsconfig.option.json | ||
tsconfig.eslint.json | ||
CHANGELOG.md |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
{ | ||
"arrowParens": "avoid", | ||
"bracketSpacing": true, | ||
"jsxBracketSameLine": false, | ||
"printWidth": 100, | ||
"proseWrap": "always", | ||
"requirePragma": false, | ||
"semi": true, | ||
"singleQuote": true, | ||
"tabWidth": 2, | ||
"trailingComma": "all", | ||
"useTabs": false | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,83 @@ | ||
module.exports = { | ||
"bail": false, | ||
"collectCoverageFrom": [ | ||
"**/src/**/*.{ts,tsx,js,jsx}", | ||
"**/test/**/*.{ts,tsx,js,jsx}" | ||
], | ||
"coverageDirectory": "./coverage", | ||
"coveragePathIgnorePatterns": [ | ||
"coverage/", | ||
"node_modules/", | ||
"public/", | ||
"esm/", | ||
"lib/", | ||
"tmp/", | ||
"dist/" | ||
], | ||
"coverageReporters": [ | ||
"lcov", | ||
"json-summary", | ||
"html" | ||
], | ||
"coverageThreshold": { | ||
"global": { | ||
"branches": 0, | ||
"functions": 0, | ||
"lines": 0, | ||
"statements": 0 | ||
} | ||
}, | ||
"globals": { | ||
"__DEV__": true, | ||
"caches": true | ||
}, | ||
"moduleFileExtensions": [ | ||
"mock.js", | ||
"ts", | ||
"tsx", | ||
"js", | ||
"jsx", | ||
"json", | ||
"node" | ||
], | ||
"moduleNameMapper": { | ||
"^.+\\.(ttf|eot|otf|svg|woff|woff2|mp3|png|jpg|jpeg|gif|ico)$": "<rootDir>/node_modules/@airbnb/config-jest/mocks/file.js", | ||
"\\.(jpg|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga)$": "<rootDir>/__mocks__/fileMock.js", | ||
"\\.(css|less)$": "identity-obj-proxy" | ||
}, | ||
"roots": [ | ||
"<rootDir>/packages", | ||
"<rootDir>/plugins" | ||
], | ||
"setupFiles": [ | ||
"<rootDir>/node_modules/@airbnb/config-jest/setup/shims.js", | ||
"<rootDir>/node_modules/@airbnb/config-jest/setup/console.js", | ||
"<rootDir>/node_modules/@airbnb/config-jest/setup/dom.js" | ||
], | ||
"setupFilesAfterEnv": [ | ||
"<rootDir>/node_modules/@airbnb/config-jest/bootstrap/react.js", | ||
"<rootDir>/node_modules/@airbnb/config-jest/bootstrap/consumer.js", | ||
"@airbnb/config-jest/enzyme" | ||
], | ||
"testEnvironment": "jsdom", | ||
"testURL": "http://localhost", | ||
"timers": "real", | ||
"verbose": false, | ||
"transformIgnorePatterns": [ | ||
"node_modules/(?!(vega-lite|lodash-es))" | ||
], | ||
"testPathIgnorePatterns": [ | ||
"packages/generator-superset/generators" | ||
], | ||
"projects": [ | ||
"<rootDir>", | ||
{ | ||
"displayName": "node", | ||
"rootDir": "<rootDir>/packages/generator-superset", | ||
"testMatch": [ | ||
"<rootDir>/test/**/?(*.)+(spec|test).{js,jsx,ts,tsx}" | ||
], | ||
"testEnvironment": "node" | ||
} | ||
] | ||
}; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Configs still generated by Missing EOF new line is from |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep running into this error on test files:
Above line is the fix, but there is no easy way to add it to
nimbus
so I decided to just manually manage all build configs in Git.