This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
fix(chart-controls): transform emotion css prop #1036
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
Emotion's css prop must be transpiled to use emotion's
jsx
function. Not doing this is will result in missing styles when the built React components (plugin/lib/../Component.js
) are used insuperset-frontend
. This affect only production builds, and notnpm link
becausenpm link
usesplugin/src/../Components.tsx
, which can be picked up bysuperset-frontend
's Babel emotion plugin.Tested by temporarily disable
src
replacement logic insuperset-frontend
'swebpack.config.js
.Related: apache/superset#13758 (comment)