This repository has been archived by the owner on Jan 9, 2020. It is now read-only.
V0.2 dev #341
Closed
V0.2 dev #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: duyanghao <[email protected]>
….driver.pod.name` Signed-off-by: duyanghao <[email protected]>
mccheah
reviewed
Jun 9, 2017
| @@ -261,7 +281,8 @@ private[spark] object Client { | |||
| .getOrElse(Array.empty[String]) | |||
| val appName = sparkConf.getOption("spark.app.name") | |||
| .getOrElse("spark") | |||
| val kubernetesAppId = s"$appName-$launchTime".toLowerCase.replaceAll("\\.", "-") | |||
| val kubernetesAppId = sparkConf.getOption("spark.kubernetes.driver.pod.name") | |||
There was a problem hiding this comment.
I think this is out of date with branch-2.1-kubernetes - since #331 has merged, the semantics of these variables have changed.
mccheah
reviewed
Jun 9, 2017
| @@ -97,6 +102,15 @@ private[spark] class Client( | |||
| .withValue(classPath) | |||
| .build() | |||
| } | |||
| val driverCpuQuantity = new QuantityBuilder(false) | |||
|
@duyanghao is this PR still active? I'm not sure what's left since some of the pieces have been merged in through separate PRs. If there are still changes that need to be made, please open a new PR against I figured that between fixing merge conflicts and changing the destination branch from 2.1 to 2.2 it's easier to start a new PR than continue working on this one. Thanks again for helping make this project better! |
ifilonenko
pushed a commit
to ifilonenko/spark
that referenced
this pull request
Feb 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Set driver and executor Label:spark-app-id =
--conf spark.kubernetes.driver.pod.name.The main reason for this is that we can search all pods for a spark application with the specified label(
spark-app-id) value through parspark.kubernetes.driver.pod.name,which can be more easily combined with web server(if there is any),guess that use A specifies par--conf spark.kubernetes.driver.pod.name=xxx,then web server could get all pods information through k8s with label:spark-app-id=xxx,that is good anyway!!!Refs here.
How was this patch tested?
Manual tests were successful.Example is as follows:
i submit with pars:
then driver pod name and labels will be:
executor #1 pod name and labels will be:
executor #2 pod name and labels will be: