This repository has been archived by the owner on Jan 9, 2020. It is now read-only.
forked from apache/spark
-
Notifications
You must be signed in to change notification settings - Fork 118
Added log4j config for k8s unit tests #314
Merged
ash211
merged 5 commits into
apache-spark-on-k8s:branch-2.1-kubernetes
from
lins05:k8s-shuai-debug-test
Jun 9, 2017
Merged
Added log4j config for k8s unit tests #314
ash211
merged 5 commits into
apache-spark-on-k8s:branch-2.1-kubernetes
from
lins05:k8s-shuai-debug-test
Jun 9, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm surprised the core Spark testing framework doesn't give us something reasonable here. Are we perhaps not configuring something like core Spark is? |
@mccheah I don't think so. It's configured in all other modules. spark-master $ git grep -l target/unit-tests.log
R/log4j.properties
common/network-common/src/test/resources/log4j.properties
common/network-shuffle/src/test/resources/log4j.properties
core/src/test/resources/log4j.properties
external/flume-sink/src/test/resources/log4j.properties
external/flume/src/test/resources/log4j.properties
external/kafka-0-10-sql/src/test/resources/log4j.properties
external/kafka-0-10/src/test/resources/log4j.properties
external/kafka-0-8/src/test/resources/log4j.properties
external/kinesis-asl/src/main/resources/log4j.properties
external/kinesis-asl/src/test/resources/log4j.properties
graphx/src/test/resources/log4j.properties
launcher/src/test/resources/log4j.properties
mllib/src/test/resources/log4j.properties
repl/src/test/resources/log4j.properties
resource-managers/yarn/src/test/resources/log4j.properties
sql/catalyst/src/test/resources/log4j.properties
sql/core/src/test/resources/log4j.properties
sql/hive/src/test/resources/log4j.properties
streaming/src/test/resources/log4j.properties``` |
ping @mccheah |
ash211
approved these changes
Jun 8, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM will merge when build is green
foxish
pushed a commit
that referenced
this pull request
Jul 24, 2017
ifilonenko
pushed a commit
to ifilonenko/spark
that referenced
this pull request
Feb 26, 2019
puneetloya
pushed a commit
to puneetloya/spark
that referenced
this pull request
Mar 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.