Skip to content
This repository has been archived by the owner on Jan 9, 2020. It is now read-only.

Added log4j config for k8s unit tests #314

Merged

Conversation

lins05
Copy link

@lins05 lins05 commented May 30, 2017

No description provided.

@mccheah
Copy link

mccheah commented May 30, 2017

I'm surprised the core Spark testing framework doesn't give us something reasonable here. Are we perhaps not configuring something like core Spark is?

@lins05
Copy link
Author

lins05 commented May 31, 2017

@mccheah I don't think so. It's configured in all other modules.

spark-master $ git grep -l target/unit-tests.log
R/log4j.properties
common/network-common/src/test/resources/log4j.properties
common/network-shuffle/src/test/resources/log4j.properties
core/src/test/resources/log4j.properties
external/flume-sink/src/test/resources/log4j.properties
external/flume/src/test/resources/log4j.properties
external/kafka-0-10-sql/src/test/resources/log4j.properties
external/kafka-0-10/src/test/resources/log4j.properties
external/kafka-0-8/src/test/resources/log4j.properties
external/kinesis-asl/src/main/resources/log4j.properties
external/kinesis-asl/src/test/resources/log4j.properties
graphx/src/test/resources/log4j.properties
launcher/src/test/resources/log4j.properties
mllib/src/test/resources/log4j.properties
repl/src/test/resources/log4j.properties
resource-managers/yarn/src/test/resources/log4j.properties
sql/catalyst/src/test/resources/log4j.properties
sql/core/src/test/resources/log4j.properties
sql/hive/src/test/resources/log4j.properties
streaming/src/test/resources/log4j.properties```

@lins05
Copy link
Author

lins05 commented Jun 2, 2017

ping @mccheah

Copy link

@ash211 ash211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM will merge when build is green

@ash211 ash211 merged commit 2f80b1d into apache-spark-on-k8s:branch-2.1-kubernetes Jun 9, 2017
@lins05 lins05 deleted the k8s-shuai-debug-test branch June 12, 2017 12:30
foxish pushed a commit that referenced this pull request Jul 24, 2017
ifilonenko pushed a commit to ifilonenko/spark that referenced this pull request Feb 26, 2019
puneetloya pushed a commit to puneetloya/spark that referenced this pull request Mar 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants