Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add accessors for tilepart division #120

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

bradh
Copy link
Contributor

@bradh bradh commented Jan 12, 2024

This exposes the current tilepart division setting. This avoids needing a shadow variable in the libheif plugin.

Also fixes a couple of typos in the applicable enumeration. I can split that out as a separate PR if preferred.

@aous72
Copy link
Owner

aous72 commented Jan 12, 2024

Hi Brad,

This is all reasonable.

However, it is worth saying that when a tile bitstream is partitioned into multiple tile-parts, the only requirement is that each tile part contains complete precinct bitstreams; that is, a precinct bitstream cannot be broken across two tile parts.

While OpenJPH can create tile parts in a couple of specific ways (resolution, component), as you have noticed, other tools may partition the bitstream in other ways. Would that be a problem for libheif?

Cheers,
Aous.

@bradh
Copy link
Contributor Author

bradh commented Jan 12, 2024

While OpenJPH can create tile parts in a couple of specific ways (resolution, component), as you have noticed, other tools may partition the bitstream in other ways. Would that be a problem for libheif?

This is only on the libheif encoder side (i.e. setting it as an option parameter, and reading that parameter back), so I am confident it won't be a problem at this stage.

Decoding is handled separately - its a whole different plugin.

@aous72 aous72 merged commit 4a4a4d4 into aous72:master Jan 12, 2024
2 checks passed
@bradh bradh deleted the tilepart_accessors_2024-01-12 branch January 12, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants