This repository has been archived by the owner on Oct 4, 2020. It is now read-only.
Fix import bug: add aws and delete nifcloud #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aokumasan
suggested changes
Feb 5, 2020
| @@ -123,7 +123,7 @@ func rewriteServiceFile(path string) error { | |||
| func rewriteInterfaceFile(path string) error { | |||
| serviceName := filepath.Base(filepath.Dir(filepath.Dir(path))) | |||
| imports := []map[string]string{ | |||
| {"github.com/aws/aws-sdk-go-v2/aws": "github.com/aokumasan/nifcloud-sdk-go-v2/nifcloud"}, | |||
There was a problem hiding this comment.
github.com/aws/aws-sdk-go-v2/aws → github.com/aokumasan/nifcloud-sdk-go-v2/nifcloud への書き換えが不要なように見えるので、この行を削除するだけで良さそうです。
また、コードの生成は make コマンドで可能なので、すべてのファイルを生成し直してコミットしていただけると助かります。
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
computing/computingifaceをインポートするとgo vetで以下のようなエラーが発生変更内容
service/computing/computingiface/interface.goを生成するスクリプトを変更go run private/model/cli/mod-apimain.go --path service/computing/computingiface/interface.goを実行