Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rawLeaderboard.js #683

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Fix rawLeaderboard.js #683

merged 2 commits into from
Jan 2, 2025

Conversation

tyowk
Copy link
Contributor

@tyowk tyowk commented Dec 26, 2024 •
edited
Loading

Description

Fixed $rawLeaderboard filtering and added channel leaderboard type

Type of change

Please check options that describe your Pull Request:

  • Bug fix (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • My code follows the style guidelines of this project
  • Any dependent changes have been merged and published in downstream modules

Faf4a
Faf4a requested changes Jan 2, 2025
View reviewed changes
Copy link
Member

@Faf4a Faf4a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Left some thoughts on it

src/functions/rawLeaderboard.js Show resolved Hide resolved
@Faf4a Faf4a added state: pending Approval must be done first, to be accepted. aoi.js this issue/Pr is related to aoi.js labels Jan 2, 2025
@tyowk tyowk requested a review from Faf4a January 2, 2025 09:47
Faf4a
Faf4a approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@Faf4a Faf4a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks

@aoijs aoijs deleted a comment from tyowk Jan 2, 2025
@Faf4a Faf4a merged commit 14fdea0 into aoijs:v6 Jan 2, 2025
@tyowk tyowk deleted the patch-1 branch January 3, 2025 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Faf4a Faf4a Faf4a approved these changes

Assignees
No one assigned
Labels
aoi.js this issue/Pr is related to aoi.js state: pending Approval must be done first, to be accepted.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tyowk @Faf4a