-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add-about-and-posts-pages #5
Open
aoberoi
wants to merge
12
commits into
main
Choose a base branch
from
add-about-and-posts-pages
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a pretty significant refactor to the code that finds and builds post objects. This adds the concept of published and draft posts. It also reduces code duplication. And now posts are returned in a sorted order. The improved API is now used by the home page.
This is mostly cribbed from the home page. It's likely that the home page design will change significantly so its lift and shift.
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/aoberoi/aoberoi-me/81sd9Qvvo7oJqZ1FEDzGhcpogFkG |
the primary motivator for GFM is to be able to use tables in posts. this adds a sample markdown file to test out rendering of common constructs. there's also a new "environment" key in post frontmatter which allows the sample to only be visible in "development".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
/about
and/posts
pages. The are both fairly unstyled and the navigation looks pretty bad. But the lib for fetching posts was refactored in order to make the API more friendly.