refactor: remove wait time since it is the same as assigned time

anzalab · Oct 7, 2019 · b7d6b45 · b7d6b45
1 parent 8876806
commit b7d6b45
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 107 deletions.
diff --git a/src/base/facets.js b/src/base/facets.js
@@ -27,9 +27,6 @@ const METRIC_TIMES = {
   maximumCallTime: { $max: '$call.duration.milliseconds' },
   minimumCallTime: { $min: '$call.duration.milliseconds' },
   averageCallTime: { $avg: '$call.duration.milliseconds' },
-  maximumWaitTime: { $max: '$waitTime' },
-  minimumWaitTime: { $min: '$waitTime' },
-  averageWaitTime: { $avg: '$waitTime' },
   maximumWorkTime: { $max: '$workTime' },
   minimumWorkTime: { $min: '$workTime' },
   averageWorkTime: { $avg: '$workTime' },

diff --git a/src/base/servicerequest.base.js b/src/base/servicerequest.base.js
@@ -290,13 +290,6 @@ const METRIC_TIMES_FIELDS = {
    * marked as complete
    */
   workTime: { $subtract: ['$completedAt', '$assignedAt'] },
-
-  /**
-   * This is the time elapsed between when service request have been confirmed
-   * (reported by an operator) and when is have been assigned to someone to work
-   * on it
-   */
-  waitTime: { $subtract: ['$assignedAt', '$confirmedAt'] },
 };
 
 /* fields that can be added service request base aggregation */

diff --git a/src/util.js b/src/util.js
@@ -78,7 +78,6 @@ export const normalizeMetricTimes = data => {
     'resolveTime',
     'lateTime',
     'callTime',
-    'waitTime',
     'workTime',
   ];
 
@@ -118,9 +117,6 @@ export const normalizeMetricTimes = data => {
     'maximumCallTime',
     'minimumCallTime',
     'averageCallTime',
-    'maximumWaitTime',
-    'minimumWaitTime',
-    'averageWaitTime',
     'maximumWorkTime',
     'minimumWorkTime',
     'averageWorkTime',

diff --git a/test/unit/util.spec.js b/test/unit/util.spec.js
@@ -123,9 +123,6 @@ describe('Utils', () => {
         maximumWorkTime: 0,
         minimumWorkTime: 0,
         averageWorkTime: 0,
-        maximumWaitTime: 0,
-        minimumWaitTime: 0,
-        averageWaitTime: 0,
       };
 
       const expectedOutput = {
@@ -421,35 +418,6 @@ describe('Utils', () => {
             seconds: 0,
           },
         },
-        waitTime: {
-          average: {
-            days: 0,
-            hours: 0,
-            microseconds: 0,
-            milliseconds: 0,
-            minutes: 0,
-            nanoseconds: 0,
-            seconds: 0,
-          },
-          maximum: {
-            days: 0,
-            hours: 0,
-            microseconds: 0,
-            milliseconds: 0,
-            minutes: 0,
-            nanoseconds: 0,
-            seconds: 0,
-          },
-          minimum: {
-            days: 0,
-            hours: 0,
-            microseconds: 0,
-            milliseconds: 0,
-            minutes: 0,
-            nanoseconds: 0,
-            seconds: 0,
-          },
-        },
         resolved: 2,
       };
 
@@ -493,9 +461,6 @@ describe('Utils', () => {
               maximumCallTime: 0,
               minimumCallTime: 0,
               averageCallTime: 0,
-              maximumWaitTime: null,
-              minimumWaitTime: null,
-              averageWaitTime: null,
               maximumWorkTime: null,
               minimumWorkTime: null,
               averageWorkTime: null,
@@ -804,35 +769,6 @@ describe('Utils', () => {
                 seconds: 0,
               },
             },
-            waitTime: {
-              average: {
-                days: 0,
-                hours: 0,
-                microseconds: 0,
-                milliseconds: 0,
-                minutes: 0,
-                nanoseconds: 0,
-                seconds: 0,
-              },
-              maximum: {
-                days: 0,
-                hours: 0,
-                microseconds: 0,
-                milliseconds: 0,
-                minutes: 0,
-                nanoseconds: 0,
-                seconds: 0,
-              },
-              minimum: {
-                days: 0,
-                hours: 0,
-                microseconds: 0,
-                milliseconds: 0,
-                minutes: 0,
-                nanoseconds: 0,
-                seconds: 0,
-              },
-            },
             workTime: {
               average: {
                 days: 0,
@@ -1130,35 +1066,6 @@ describe('Utils', () => {
                   seconds: 0,
                 },
               },
-              waitTime: {
-                average: {
-                  days: 0,
-                  hours: 0,
-                  microseconds: 0,
-                  milliseconds: 0,
-                  minutes: 0,
-                  nanoseconds: 0,
-                  seconds: 0,
-                },
-                maximum: {
-                  days: 0,
-                  hours: 0,
-                  microseconds: 0,
-                  milliseconds: 0,
-                  minutes: 0,
-                  nanoseconds: 0,
-                  seconds: 0,
-                },
-                minimum: {
-                  days: 0,
-                  hours: 0,
-                  microseconds: 0,
-                  milliseconds: 0,
-                  minutes: 0,
-                  nanoseconds: 0,
-                  seconds: 0,
-                },
-              },
               workTime: {
                 average: {
                   days: 0,