Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add coinbase wallet-adapter #444

Merged
merged 3 commits into from
Jun 27, 2022

Conversation

brianchitester
Copy link
Contributor

Summary

This PR adds a wallet adapter for Coinbase Wallet. Solana is supported in Coinbase Wallet browser extension v.2.20 and higher.

Testing

  1. Ensure you have Coinbase Wallet browser extension v.2.20 or higher installed
  2. Enable Experiment Mode from advanced settings. Go to Settings > Advanced Settings > Developer Mode
  3. Add CoinbaseWalletAdapter to your dapps supported wallets in WalletProvider
  4. Interact with the dapp using Coinbase Wallet

@brianchitester brianchitester marked this pull request as ready for review June 22, 2022 23:19
Copy link
Collaborator

@jordaaash jordaaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! The main thing that should get refactored out is the hacks that were copied over from the Phantom adapter.

packages/wallets/coinbase/package.json Outdated Show resolved Hide resolved
packages/wallets/coinbase/package.json Outdated Show resolved Hide resolved
packages/wallets/coinbase/src/adapter.ts Outdated Show resolved Hide resolved
packages/wallets/coinbase/src/adapter.ts Outdated Show resolved Hide resolved
packages/wallets/coinbase/src/adapter.ts Outdated Show resolved Hide resolved
packages/wallets/coinbase/src/adapter.ts Outdated Show resolved Hide resolved
packages/wallets/wallets/package.json Outdated Show resolved Hide resolved
@jordaaash
Copy link
Collaborator

I also want to note, that while the medium-term goal is to move away from requiring adapters for every wallet, I want to respect the time you took to create this adapter, and review it now.

Once a new standard is introduced, let's work together to migrate away from dependency on using an adapter.

@jordaaash jordaaash merged commit 2ac181a into anza-xyz:master Jun 27, 2022
@jordaaash
Copy link
Collaborator

Thank you! This will get released tomorrow.

@jordaaash
Copy link
Collaborator

Published! https://twitter.com/jordaaash/status/1541927694786600961

@silvestrevivo
Copy link
Contributor

@brianchitester is currently possible to choose the Solana network in the Coinbase wallet? I've just installed following your instructions, I can connect but I can not choose the Solana network and make any transaction. Thanks!

@brianchitester
Copy link
Contributor Author

@silvestrevivo can you provide screenshots or steps to reproduce the issue you're seeing to help narrow it down for me?

@silvestrevivo
Copy link
Contributor

silvestrevivo commented Jun 29, 2022

@brianchitester sure, here down below the available networks.

Screenshot Screenshot Screenshot Screenshot
Screenshot 2022-06-29 at 19 27 45 Screenshot 2022-06-29 at 19 27 54 Screenshot 2022-06-29 at 19 28 03 Screenshot 2022-06-29 at 19 28 10

There is no way to work on Solana Devnet?

@mayoyml
Copy link

mayoyml commented Jul 5, 2022

@brianchitester Hi 👋 , I am wondering when the Solana network is available. I cannot find the option from the extension

@silvestrevivo
Copy link
Contributor

@mayoyml I was testing the wallet too and the only way to have solana working is transferring money to the wallet (at least on mainnet). But you are right, it is pretty strange that Solana is not visible there yet. Even there is no change to add DevNet or TestNet for development purpose.

@brianchitester any updates regarding this? Thanks!

@mayoyml
Copy link

mayoyml commented Jul 6, 2022

@silvestrevivo Thank you so much for answering the question! It's super helpful.
@brianchitester Let us know if there are any updates! 🙏

@brianchitester
Copy link
Contributor Author

@silvestrevivo @mayoyml Dev/testnet is not yet available in the extension but the team is working on it for future release. I will keep you posted. For mainnet you may need to enable experiment mode under advanced settings depending on your extension version. Thank you for your patience as we roll out full Solana support.

@mayoyml
Copy link

mayoyml commented Jul 7, 2022

@brianchitester Thanks for the reply! Cannot wait to support the Solana feature!

@silvestrevivo
Copy link
Contributor

@brianchitester thanks for the reply!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants