-
Notifications
You must be signed in to change notification settings - Fork 972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add coinbase wallet-adapter #444
add coinbase wallet-adapter #444
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! The main thing that should get refactored out is the hacks that were copied over from the Phantom adapter.
I also want to note, that while the medium-term goal is to move away from requiring adapters for every wallet, I want to respect the time you took to create this adapter, and review it now. Once a new standard is introduced, let's work together to migrate away from dependency on using an adapter. |
Thank you! This will get released tomorrow. |
@brianchitester is currently possible to choose the Solana network in the Coinbase wallet? I've just installed following your instructions, I can connect but I can not choose the Solana network and make any transaction. Thanks! |
@silvestrevivo can you provide screenshots or steps to reproduce the issue you're seeing to help narrow it down for me? |
@brianchitester sure, here down below the available networks.
There is no way to work on Solana Devnet? |
@brianchitester Hi 👋 , I am wondering when the Solana network is available. I cannot find the option from the extension |
@mayoyml I was testing the wallet too and the only way to have solana working is transferring money to the wallet (at least on mainnet). But you are right, it is pretty strange that Solana is not visible there yet. Even there is no change to add DevNet or TestNet for development purpose. @brianchitester any updates regarding this? Thanks! |
@silvestrevivo Thank you so much for answering the question! It's super helpful. |
@silvestrevivo @mayoyml Dev/testnet is not yet available in the extension but the team is working on it for future release. I will keep you posted. For mainnet you may need to enable experiment mode under advanced settings depending on your extension version. Thank you for your patience as we roll out full Solana support. |
@brianchitester Thanks for the reply! Cannot wait to support the Solana feature! |
@brianchitester thanks for the reply!!! |
Summary
This PR adds a wallet adapter for Coinbase Wallet. Solana is supported in Coinbase Wallet browser extension v.2.20 and higher.
Testing
CoinbaseWalletAdapter
to your dapps supported wallets inWalletProvider