Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wallet adapter for NuFi #431

Merged
merged 6 commits into from
Jun 28, 2022
Merged

Add wallet adapter for NuFi #431

merged 6 commits into from
Jun 28, 2022

Conversation

gyorgy-kurucz-vacuum
Copy link
Contributor

@gyorgy-kurucz-vacuum gyorgy-kurucz-vacuum commented May 25, 2022

This adds support for the upcoming NuFi extension.

(The interface is based on Phantom's, they should be compatible, except for changing the window.solana key to window.nufiSolana of course.)

@jordaaash
Copy link
Collaborator

Hey, I want to address the lack of activity on your PR. Thank you for your patience!

Here's a followup on the state of wallet-adapter, the issues that individual adapters have in getting integrated with applications, and how we intend to improve things: #384 (comment)

Let's discuss in that thread to keep it in one place.

Copy link
Collaborator

@jordaaash jordaaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the medium-term goal is to move away from requiring adapters for every wallet, I want to respect the time you took to create this adapter, and review it now.

Once a new standard is introduced, let's work together to migrate away from dependency on using an adapter.

packages/wallets/nufi/src/adapter.ts Outdated Show resolved Hide resolved
packages/wallets/nufi/src/adapter.ts Outdated Show resolved Hide resolved
packages/wallets/nufi/src/publicTypes.ts Outdated Show resolved Hide resolved
@gyorgy-kurucz-vacuum
Copy link
Contributor Author

Thank you for the review, feel free to point out if there are any other redundant parts left as a result of copying the Phantom code that I didn't catch.

packages/wallets/nufi/src/adapter.ts Outdated Show resolved Hide resolved
packages/wallets/nufi/src/adapter.ts Show resolved Hide resolved
packages/wallets/nufi/src/adapter.ts Outdated Show resolved Hide resolved
packages/wallets/nufi/src/adapter.ts Outdated Show resolved Hide resolved
@jordaaash jordaaash merged commit 757e92b into anza-xyz:master Jun 28, 2022
@jordaaash
Copy link
Collaborator

Thanks! This will be published today or tomorrow.

@jordaaash
Copy link
Collaborator

Published! https://twitter.com/jordaaash/status/1541927694786600961

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants