-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wallet adapter for NuFi #431
Conversation
Hey, I want to address the lack of activity on your PR. Thank you for your patience! Here's a followup on the state of wallet-adapter, the issues that individual adapters have in getting integrated with applications, and how we intend to improve things: #384 (comment) Let's discuss in that thread to keep it in one place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the medium-term goal is to move away from requiring adapters for every wallet, I want to respect the time you took to create this adapter, and review it now.
Once a new standard is introduced, let's work together to migrate away from dependency on using an adapter.
Thank you for the review, feel free to point out if there are any other redundant parts left as a result of copying the Phantom code that I didn't catch. |
Co-authored-by: Jordan Sexton <[email protected]>
Thanks! This will be published today or tomorrow. |
This adds support for the upcoming NuFi extension.
(The interface is based on Phantom's, they should be compatible, except for changing the
window.solana
key towindow.nufiSolana
of course.)