Add Keystone Wallet adapter #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jordansexton would you please review our pr for adding the Keystone into the wallet adapter ? |
zhaomengru2015
force-pushed
the
keystone
branch
2 times, most recently
from
16ec8f0 to
8a14bef
Compare
|
Hey, I want to address the lack of activity on your PR. Thank you for your patience! Here's a followup on the state of wallet-adapter, the issues that individual adapters have in getting integrated with applications, and how we intend to improve things: #384 (comment) Let's discuss in that thread to keep it in one place. |
jordaaash
reviewed
Jun 22, 2022
|
@jordansexton Sorry for the delay. Thanks for reviewing and we've fixed the comments you mentioned above, please double check it. |
|
Looks good, thanks! |
|
Published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
A wallet adapter for Keystone.
How to test?
Solflaremode and select the address to sync