Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Salmon adapter #401

Merged
merged 12 commits into from
Jul 29, 2022
Merged

Add Salmon adapter #401

merged 12 commits into from
Jul 29, 2022

Conversation

salmon-h
Copy link
Contributor

Support for https://salmonwallet.io/ wallet

@jordaaash
Copy link
Collaborator

Hey, I want to address the lack of activity on your PR. Thank you for your patience!

Here's a followup on the state of wallet-adapter, the issues that individual adapters have in getting integrated with applications, and how we intend to improve things: #384 (comment)

Let's discuss in that thread to keep it in one place.

Copy link
Collaborator

@jordaaash jordaaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the medium-term goal is to move away from requiring adapters for every wallet, I want to respect the time you took to create this adapter, and review it now.

Once a new standard is introduced, let's work together to migrate away from dependency on using an adapter.

README.md Outdated Show resolved Hide resolved
packages/wallets/salmon/src/adapter.ts Outdated Show resolved Hide resolved
packages/wallets/salmon/src/base.ts Outdated Show resolved Hide resolved
Hernando Scheidl added 2 commits July 14, 2022 12:19
Copy link
Collaborator

@jordaaash jordaaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor fix / clarification, but otherwise looks good. Thanks!

packages/wallets/salmon/src/adapter.ts Outdated Show resolved Hide resolved
@jordaaash jordaaash merged commit 3a97d66 into anza-xyz:master Jul 29, 2022
@jordaaash
Copy link
Collaborator

Thanks for this! Excited that someone's taken over development of Sollet. I hope this will fix a number of the issues with it and hacks that are necessary on connecting / popup closures.

@jordaaash
Copy link
Collaborator

Published @solana/[email protected], please test it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants