Add OntoWallet adapter #284
Conversation
Co-authored-by: Jordan Sexton <[email protected]>
have updated
…i/wallet-adapter into dev-ONTO-add-adapter
|
Can you merge code please？ |
|
@jordansexton have any questions about PR ? Please check and commit, Thanks |
|
|
||
| interface OntoWallet { | ||
| isOnto?: boolean; | ||
| signTransaction(transaction: Transaction): Promise<Transaction>; |
There was a problem hiding this comment.
Is this used? It seems like the interface below is using request with sol_sign.
There was a problem hiding this comment.
@jordansexton Yes,used in Solana Dapp and App Wallet interaction.
There was a problem hiding this comment.
Hi @PieroDaVinci, the issue is that signTransaction is declared here, but on line 139 below:
const response = await wallet.request({ method: 'sol_sign', params: [transaction] });
Since only wallet.request seems to be used, I'm wondering if this method declaration is needed.
|
resolve the conflict |
|
@jordansexton Hi guys, ONTO Web3 Wallet is the most popular wallet and have Millions users，our wallet have many users of Solana，so，please check and commit～！Thanks |
|
Hey, I want to address the lack of activity on your PR. Thank you for your patience! Here's a followup on the state of wallet-adapter, the issues that individual adapters have in getting integrated with applications, and how we intend to improve things: #384 (comment) Let's discuss in that thread to keep it in one place. |
There was a problem hiding this comment.
While the medium-term goal is to move away from requiring adapters for every wallet, I want to respect the time you took to create this adapter, and review it now.
Once a new standard is introduced, let's work together to migrate away from dependency on using an adapter.
|
|
||
| interface OntoWallet { | ||
| isOnto?: boolean; | ||
| signTransaction(transaction: Transaction): Promise<Transaction>; |
There was a problem hiding this comment.
Hi @PieroDaVinci, the issue is that signTransaction is declared here, but on line 139 below:
const response = await wallet.request({ method: 'sol_sign', params: [transaction] });
Since only wallet.request seems to be used, I'm wondering if this method declaration is needed.
|
|
||
| export const OntoWalletName = 'ONTO' as WalletName; | ||
|
|
||
| export class Coin98WalletAdapter extends BaseSignerWalletAdapter { |
There was a problem hiding this comment.
This was copied from Coin98, please fix and review for any other copied sections.
| | [torus](https://github.com/solana-labs/wallet-adapter/tree/master/packages/wallets/torus) | Adapter for [Torus](https://tor.us) | [`@solana/wallet-adapter-torus`](https://npmjs.com/package/@solana/wallet-adapter-torus) | | ||
| | [walletconnect](https://github.com/solana-labs/wallet-adapter/tree/master/packages/wallets/walletconnect) \* | Adapter for [WalletConnect](https://walletconnect.org) | [`@solana/wallet-adapter-walletconnect`](https://npmjs.com/package/@solana/wallet-adapter-walletconnect) | | ||
| | [onto](https://github.com/solana-labs/wallet-adapter/tree/master/packages/wallets/onto) | Adapter for [onto](https://onto.app) | [`@solana/wallet-adapter-onto`](https://npmjs.com/package/@solana/wallet-adapter-onto) | | ||
|
|
There was a problem hiding this comment.
Can you also merge in the latest from the master branch? It looks like the README changes may be out of sync here.
|
Closing this PR since there's been no activity for over a month. Please let me know if you've made the changes above and I'll reopen! |
No description provided.