feat: add ledger signMessage #1047
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this is Bytezhang from the OneKey team.
The SOL community has always lacked a secure way to implement signMessage, and the current methods for account verification within the ecosystem vary greatly.
Currently, Ledger has a solution called signOffchainMessage. I noticed a previous PR (#712) that directly added support to signMessage, but its implementation has issues. I’ve stepped in to complete it properly.
However, I have a question: would it be better to add a signOffchainMessage method in the Standard Wallet instead?
If that’s feasible, I’ll close this PR and submit a new one to the Standard Wallet to support signOffchainMessage. Afterward, I’ll come back to this repo to add signOffchainMessage support for Ledger.