[BPF] Allow selectively disable compiler builtins for BPF target #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the calls to rust alloc/dealloc routines need to be preserved and not replaced by compiler generated builtin inlined code
jackcmay
reviewed
Feb 17, 2021
| @@ -1503,9 +1509,9 @@ bool TargetLibraryInfoImpl::getLibFunc(const Function &FDecl, | |||
| LibFunc &F) const { | |||
| // Intrinsics don't overlap w/libcalls; if our module has a large number of | |||
| // intrinsics, this ends up being an interesting compile time win since we | |||
| // avoid string normalization and comparison. | |||
There was a problem hiding this comment.
These changes probably not necessary
There was a problem hiding this comment.
let's keep it... the trailing white space is bad in source code (my editor automatically deletes it on saving a file)
jackcmay
reviewed
Feb 17, 2021
| @@ -550,6 +550,12 @@ static void initialize(TargetLibraryInfoImpl &TLI, const Triple &T, | |||
| TLI.setUnavailable(LibFunc_nvvm_reflect); | |||
| } | |||
|
|
|||
| if (T.isBPF()) { | |||
| TLI.setUnavailable(LibFunc_rust_alloc); | |||
There was a problem hiding this comment.
Why does llvm have to have any knowledge of these rust functions?
There was a problem hiding this comment.
it does. It replaces them with internal built-ins, which these calls to TLI.setUnavailable() prevent from happening.
LucasSte
pushed a commit
that referenced
this pull request
Feb 16, 2024
* [BPF] Make rust allocation builtins unavailable for BPF target - the calls to rust alloc/dealloc routines need to be preserved and not replaced by compiler generated builtin inlined code
LucasSte
pushed a commit
to LucasSte/llvm-project
that referenced
this pull request
Jun 28, 2024
…a-xyz#4) * [BPF] Make rust allocation builtins unavailable for BPF target - the calls to rust alloc/dealloc routines need to be preserved and not replaced by compiler generated builtin inlined code
LucasSte
pushed a commit
that referenced
this pull request
Aug 19, 2024
* [BPF] Make rust allocation builtins unavailable for BPF target - the calls to rust alloc/dealloc routines need to be preserved and not replaced by compiler generated builtin inlined code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.