[zk-token-sdk] Rename FeeSigmaProof to PercentageWithCapProof
#748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samkim-crypto
force-pushed
the
zk-token-sdk/percentage-with-cap-proof
branch
from
6fac65b to
6d257f9
Compare
samkim-crypto
force-pushed
the
zk-token-sdk/percentage-with-cap-proof
branch
from
bc72848 to
af8d8d8
Compare
|
Instead of making the name changes in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The zk-token-sdk and zk-token-proof program use module and instruction names that are unnecessarily specific to the token extension confidential transfer application. The tools for these modules can be used more generally for a wider set of cryptographic and zk applications.
In particualr, the
FeeSigmaProofcan be more aptly namedPercentageWithCapProof, which is more descriptive of what it the proof is actually proving.Summary of Changes
Update the sigma proof type name from
FeeSigmaProoftoPercentageWithCapProof. This PR updates only the sigma proof and zk-token-elgamal type names to minimize disruption to the CI. I'll update the instruction names in a follow-up.This is part of #671.
Fixes #