Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower pps to 25k #705

Closed
wants to merge 2 commits into from
Closed

Conversation

lijunwangs
Copy link

Problem

It has been found with 250K PPS, the streamer is sending down excessive amount of packets down stream to cause issues with skip rate increasing.

Summary of Changes

Lower the max streams per second to 25K.

Fixes #

@lijunwangs lijunwangs requested review from pgarg66 and t-nelson April 10, 2024 08:08
@aeyakovenko
Copy link

@lijunwangs isn't this inconclusive? I am not sure if the issue is max pps or lack of client side backoff. Once client side back off is fixed, it makes sense to figure out the max capacity of the pipeline

@lijunwangs
Copy link
Author

@lijunwangs isn't this inconclusive? I am not sure if the issue is max pps or lack of client side backoff. Once client side back off is fixed, it makes sense to figure out the max capacity of the pipeline

I thought it was clear the lower level cannot handle that much of packets? And you mentioned the system is going through 1K txn /s only. Even 25K is much larger than that... I will defer this PR to another day after the backoff implementation has more data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants