-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove reclaim param for store_accounts_frozen #618
Remove reclaim param for store_accounts_frozen #618
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there still legitimate, non-test, uses for StoreReclaims::Default
? Or can we rip out StoreReclaims
entirely?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #618 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 851 851
Lines 230224 230222 -2
=========================================
- Hits 188527 188525 -2
Misses 41697 41697 |
@brooksprumo |
probably we can rip it out in follow on prs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problem
Follow up #581.
store_frozen_account
should never populate reclaims.Summary of Changes
Remove
reclaim
param fromstore_frozen_account
.Fixes #