v1.18: add metric for duplicate push messages (backport of #321) #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* add metric for duplicate push messages * add in num_total_push * address comments. don't lock stats each time * address comments. remove num_total_push * change dup push message name in code to reflect metric name (cherry picked from commit 04feed2)
behzadnouri
approved these changes
Mar 29, 2024
gregcusack
added
the
automerge
anwayde
pushed a commit
to firedancer-io/agave
that referenced
this pull request
Jul 23, 2024
…) (anza-xyz#505) add metric for duplicate push messages (anza-xyz#321) * add metric for duplicate push messages * add in num_total_push * address comments. don't lock stats each time * address comments. remove num_total_push * change dup push message name in code to reflect metric name (cherry picked from commit 04feed2) Co-authored-by: Greg Cusack <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We don't have any insight into what percentage of gossiped crds values are duplicates (or redundant)
Summary of Changes
Add a metric:
num_duplicate_pushthat reports the number of duplicateCrdsValues received via push.num_total_pushthat reports the total number ofCrdsValues received via push200 node test cluster on Monogon shows about 53% of Push messages are duplicates
This is an automatic backport of pull request #321 done by [Mergify](https://mergify.com).