clap-utils: Add more compute unit helpers #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samkim-crypto
previously approved these changes
Mar 27, 2024
| .value_name("COMPUTE-UNIT-PRICE") | ||
| .help(COMPUTE_UNIT_PRICE_ARG.help) | ||
| } | ||
| pub use crate::compute_budget::{compute_unit_price_arg, COMPUTE_UNIT_PRICE_ARG}; |
There was a problem hiding this comment.
One suggestion could be to deprecate the re-export with a message to use them directly from compute_budget instead as done here. However, this doesn't really do anything in terms of triggering warnings (solana-labs#33276 (comment)), so it is your call.
There was a problem hiding this comment.
Yeah that was my thinking too, but I guess it can't hurt to document the code. Done!
samkim-crypto
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While working on adding compute budget instructions to CLIs, I've noticed some bits missing in the clap-utils:
Summary of Changes
Pretty simple: add a compute unit limit arg to clap-utils, and both args to clap-v3-utils.
While working on this, it made sense to move the current
compute_unit_pricehelper into a more generalcompute_budgetmodule. Let me know how this looks!