Apply AccountsFileProvider to more functions #439
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhchiang-sol
force-pushed
the
ap-more-functions
branch
from
5365c11 to
1572224
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #439 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 841 841
Lines 228267 228298 +31
=========================================
+ Hits 186924 186947 +23
- Misses 41343 41351 +8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#334 introduces AccountsFileProvider trait to start allowing functions
to switch between different AccountsFile implementations, but most
functions are still using hard-coded AppendVecProvider instead of
taking a generic.
Summary of Changes
Apply generic AccountsFileProvider to more functions, but still leave
the top-level caller to use AppendVecProvider.
Dependencies
#334