Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove solana-sdk from solana-system-program #4037

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

kevinheavey
Copy link

Problem

This crate only needs solana-sdk in dev-dependencies

Summary of Changes

Remove it from normal deps and replace with constituent crates

@kevinheavey kevinheavey requested a review from a team as a code owner December 10, 2024 10:55
Copy link

mergify bot commented Dec 10, 2024

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@LucasSte LucasSte added the CI Pull Request is ready to enter CI label Dec 10, 2024
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Dec 10, 2024
@LucasSte LucasSte added the automerge automerge Merge this Pull Request automatically once CI passes label Dec 10, 2024
Copy link

mergify bot commented Dec 10, 2024

automerge label removed due to a CI failure

@mergify mergify bot removed the automerge automerge Merge this Pull Request automatically once CI passes label Dec 10, 2024
@kevinheavey kevinheavey force-pushed the system-program-rm-sdk branch from ce149e5 to 7ef575c Compare December 10, 2024 15:56
@kevinheavey kevinheavey added the automerge automerge Merge this Pull Request automatically once CI passes label Dec 10, 2024
@mergify mergify bot merged commit 2cea8e6 into anza-xyz:master Dec 10, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge Merge this Pull Request automatically once CI passes need:merge-assist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants