Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused dependencies from solana-program-runtime #4015

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

conr2d
Copy link

@conr2d conr2d commented Dec 9, 2024

Problem

libc is not used in solana-program-runtime any more.

Summary of Changes

This PR removes libc from the dependencies of solana-program-runtime.

@conr2d conr2d requested a review from a team as a code owner December 9, 2024 14:54
@pgarg66 pgarg66 added the CI Pull Request is ready to enter CI label Dec 9, 2024
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Dec 9, 2024
@pgarg66
Copy link

pgarg66 commented Dec 9, 2024

Hey @conr2d, the Cargo.lock files need to be updated as well. See https://buildkite.com/anza/agave/builds/15493#0193ac15-2107-4820-a646-6b33a603a620/190-199

Can you push an update to the PR?

@pgarg66 pgarg66 added the CI Pull Request is ready to enter CI label Dec 9, 2024
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Dec 9, 2024
@pgarg66 pgarg66 added the CI Pull Request is ready to enter CI label Dec 9, 2024
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Dec 9, 2024
@pgarg66 pgarg66 added the CI Pull Request is ready to enter CI label Dec 10, 2024
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Dec 10, 2024
@conr2d conr2d changed the title remove unused libc from solana-program-runtime remove unused dependencies from solana-program-runtime Dec 10, 2024
@pgarg66 pgarg66 added the CI Pull Request is ready to enter CI label Dec 10, 2024
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Dec 10, 2024
@pgarg66
Copy link

pgarg66 commented Dec 10, 2024

Hey @Lichtso, any concerns with merging this PR?

@joncinque joncinque merged commit 0c26485 into anza-xyz:master Dec 11, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants