Wait for at least one account to have been created before starting the account benchmarks #3960
Conversation
accounts-cluster-bench/src/main.rs
Outdated
| let exit = exit.clone(); | ||
| let max_closed = seed_tracker.max_closed.clone(); | ||
| let max_created = seed_tracker.max_created.clone(); | ||
| let mint = *mint; | ||
| Builder::new() | ||
| .name(format!("rpc-bench-{}", thread)) | ||
| .spawn(move || { | ||
| start.recv().unwrap(); |
There was a problem hiding this comment.
Prevents run_rpc_bench_loop from being executed until it receives the signal.
steveluscher
added
the
automerge
|
automerge label removed due to a CI failure |
mergify
bot
removed
the
automerge
steveluscher
force-pushed
the
wait-to-start-bench
branch
2 times, most recently
from
2038b8a to
439fd26
Compare
…e account benchmarks
steveluscher
force-pushed
the
wait-to-start-bench
branch
from
439fd26 to
42b6cfc
Compare
|
Updated implementation to use |
|
@steveluscher Can you please do not merge with red CI. @yihau didn't we have a check to prevent people to merge without a green CI. |
Wild. I'm really diligent about this. Let me see what happened here. |
|
I see what happened. I had a ton of PRs in a stack, none of which pushed this method over the limit itself, but the rebased version of this one (on top of one of the others) did. I'll send a PR to fix that now. |
Problem
Consider a benchmark like the one in #3959. Presently, that PR causes a lot of this to be echoed when the benchmark first starts up:
Summary of Changes
Wait on the creation of the first accounts before starting the benchmark.
Related: #3959.