-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.0: Fix reserve minimal compute units for builtins (backport of #3799) #3930
base: v2.0
Are you sure you want to change the base?
Conversation
- Add feature gate, issue #2562; - Implement SIMD-170; --------- Co-authored-by: Justin Starry <[email protected]> (cherry picked from commit 3e9af14) # Conflicts: # builtins-default-costs/src/lib.rs # compute-budget/src/compute_budget_limits.rs # compute-budget/src/compute_budget_processor.rs # core/src/banking_stage/consumer.rs # core/src/banking_stage/immutable_deserialized_packet.rs # core/src/banking_stage/transaction_scheduler/receive_and_buffer.rs # cost-model/src/cost_model.rs # cost-model/src/transaction_cost.rs # programs/compute-budget-bench/benches/compute_budget.rs # programs/sbf/tests/programs.rs # runtime-transaction/benches/process_compute_budget_instructions.rs # runtime-transaction/src/compute_budget_instruction_details.rs # runtime-transaction/src/compute_budget_program_id_filter.rs # runtime-transaction/src/lib.rs # runtime-transaction/src/runtime_transaction.rs # runtime-transaction/src/runtime_transaction/sdk_transactions.rs # runtime/src/bank.rs # runtime/src/bank/tests.rs # runtime/src/prioritization_fee_cache.rs # sdk/src/feature_set.rs # svm-transaction/src/svm_message.rs # svm-transaction/src/svm_message/sanitized_message.rs # svm-transaction/src/svm_message/sanitized_transaction.rs # svm/src/transaction_processor.rs # transaction-view/src/resolved_transaction_view.rs # transaction-view/src/transaction_view.rs
Cherry-pick of 3e9af14 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
this has been untouched with conflicts for two weeks. can we close it? |
I also think better not to backport this one, but let me sync up w @jstarry tomorrow when he's back. |
Problem
Implementing solana-foundation/solana-improvement-documents#170 by defining MAX_BUILTIN_ALLOCATION_COMPUTE_UNIT_LIMIT to 3K CUs, then use it to allocate builtin instructions' CU Meters for VM and cost tracking for leaders.
Summary of Changes
Feature Gate Issue: #2562
This is an automatic backport of pull request #3799 done by [Mergify](https://mergify.com).