Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formats logs in calc_delete_dependencies() #3925

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

brooksprumo
Copy link

@brooksprumo brooksprumo commented Dec 4, 2024

Problem

Some logs in calc_delete_dependencies() are not formatted in a grep-friendly way.

Multi-line output is nice for human-readability, but when trying to grep through many thousands of these lines, it's much harder. Instead, log on a single line. Just ensure that the slot list is last, so it's still easy to see the pubkey, ref count, and slot list len.

Summary of Changes

Fix 'em.

@brooksprumo brooksprumo self-assigned this Dec 4, 2024
@brooksprumo brooksprumo marked this pull request as ready for review December 4, 2024 20:46
@brooksprumo brooksprumo requested review from HaoranYi and removed request for HaoranYi December 4, 2024 20:46
@brooksprumo brooksprumo marked this pull request as draft December 4, 2024 20:57
@brooksprumo brooksprumo force-pushed the calc-delete-dependencies branch from b8d9fee to b2f1b3c Compare December 4, 2024 21:25
@brooksprumo brooksprumo marked this pull request as ready for review December 4, 2024 22:36
Copy link

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Copy link

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brooksprumo brooksprumo merged commit 058e988 into anza-xyz:master Dec 5, 2024
40 checks passed
@brooksprumo brooksprumo deleted the calc-delete-dependencies branch December 5, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants