v2.0: ledger-tool: Make blockstore slot functional with no tx metadata (backport of #2423) #3887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
A previous commit unified the code to output a slot between the bigtable block and blockstore slot commands. In doing so, support for blockstore slot when tx metadata is absent was unintentionally broken This re-adds support for using the blockstore slot command when the blockstore does not contain tx metadata (cherry picked from commit ee0667d)
steviez
reviewed
Dec 3, 2024
There was a problem hiding this comment.
Justification for v2.0 PR - the blockstore slot command is broken at the moment for nodes that do not have --enable-rpc-transaction-data. This is likely most voting validators, so having the command not work and return the following error is annoying:
error getting entries from slot: X: MissingTransactionMetadata
missing transaction metadata
These changes are fairly restricted to ledger-tool, so I think it is fine for the BP to v2.0 at this point in the life cycle
sakridge
approved these changes
Dec 3, 2024
bw-solana
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A previous command consolidated code between the bigtable block and blockstore slot commands. In doing so, support for running the slot command on partial blocks was removed. However, support for running the command when tx metadata is absent was also accidentally removed.
Summary of Changes
This change re-adds the ability for the slot command to print transaction information even when the the blockstore does not contain transaction metadata.
This is an automatic backport of pull request #2423 done by Mergify.