[TieredStorage] Use mmap.len() in TieredStorage::file_size() for HotStorage #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhchiang-sol
force-pushed
the
ts-cache-file-size
branch
from
c59ee2e to
f107708
Compare
yhchiang-sol
force-pushed
the
ts-cache-file-size
branch
3 times, most recently
from
30ff8bf to
86be04e
Compare
yhchiang-sol
force-pushed
the
ts-cache-file-size
branch
from
86be04e to
3058abf
Compare
brooksprumo
approved these changes
Mar 22, 2024
| .and_then(|file| file.metadata()) | ||
| .map(|metadata| metadata.len()) | ||
| .unwrap_or(0)) | ||
| Ok(self.reader().map_or(0, |reader| reader.len())) |
There was a problem hiding this comment.
Not related to this PR directly, but why does this method return a Result? Seems like returning a u64 should be fine.
There was a problem hiding this comment.
Yep, I also noticed that. Will have a PR that have it return u64 and rename it to len() for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current implementation of TieredStorage::file_size() requires
a sys-call to provide the file size.
Summary of Changes
Add len() API to TieredStorageReader, and have HotStorageReader()
implement the API using Mmap::len().
Test Plan
Update existing unit-test to also verify HotStorageReader::len().