tests that Vec<CrdsValue> (de)serialization round trips #3710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzadnouri
force-pushed
the
gossip-test-crds-value-serialize-round-trip
branch
from
5829ddc to
45fc3ca
Compare
behzadnouri
force-pushed
the
gossip-test-crds-value-serialize-round-trip
branch
from
45fc3ca to
4ddaefd
Compare
behzadnouri
changed the title
gregcusack
reviewed
Nov 20, 2024
| num_cpus = { workspace = true } | ||
| rand0-7 = { workspace = true } | ||
| rand_chacha0-2 = { workspace = true } |
There was a problem hiding this comment.
why do we need rand_cha_cha v2 here? Can we not get away with v3?
There was a problem hiding this comment.
This code will not compile unless I use older versions for both rand and rand_chacha because Keypair::generate requires a rand 0.7 CryptoRng and rand_chacha 0.3 implements rand 0.8 CryptoRng which is not the same as 0.7 version.
There was a problem hiding this comment.
love dependency hell lol. sounds good!
gregcusack
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#3575 reworks
CrdsValue(de)serialization.Need to verify that the serialization does not change and round trips.
Summary of Changes
Vec<CrdsValue>(de)serialization.