Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move BorrowedAccountMeta and BorrowedInstruction to instruction crate #3693

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

kevinheavey
Copy link

Problem

These two small structs make solana_program::message rely on solana_program::sysvar.

Summary of Changes

Move them to solana_instruction and re-export with deprecation. I measured an increase in build time of 0.004 seconds for solana-instruction, which might not even be real.

Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me. This type is only used in the instructions sysvar, message, and svm's account loader, so moving it into solana-instruction makes the most sense over any of those other crates.

sdk/instruction/src/lib.rs Outdated Show resolved Hide resolved
sdk/instruction/src/lib.rs Outdated Show resolved Hide resolved
@joncinque joncinque added the automerge automerge Merge this Pull Request automatically once CI passes label Nov 18, 2024
@mergify mergify bot merged commit e3954be into anza-xyz:master Nov 18, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge Merge this Pull Request automatically once CI passes need:merge-assist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants