v1.18: relax stake split destination check (backport of #162) #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* relax stake split destination check * change stake_account error handling logic * fmt * modify logic * change error message when account is neither owned by stake program or system program * add a comment explaining nested ifs in stake_account error handling * fix typos in comments * update comment (cherry picked from commit 6bcb77d)
|
This is a solana-cli-only change, which is a precursor to this backport: #369 |
CriesofCarrots
approved these changes
Mar 21, 2024
CriesofCarrots
added
the
automerge
anwayde
pushed a commit
to firedancer-io/agave
that referenced
this pull request
Jul 23, 2024
…anza-xyz#368) relax stake split destination check (anza-xyz#162) * relax stake split destination check * change stake_account error handling logic * fmt * modify logic * change error message when account is neither owned by stake program or system program * add a comment explaining nested ifs in stake_account error handling * fix typos in comments * update comment (cherry picked from commit 6bcb77d) Co-authored-by: Nagaprasad V R <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #147
####Improvements
Summary of Changes
1 solana/cli/src/stake.rs
function - process_split_stake
removed some strict checks resulting in allowing system account (without data and some lamports) to be allocated as new stake account to receive split
This is an automatic backport of pull request #162 done by [Mergify](https://mergify.com).