Remove SVM's dependency on vote crate #3671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Firedancer team maintains a line-for-line reimplementation of the |
pgarg66
force-pushed
the
remove-vote-dep
branch
2 times, most recently
from
37a4b02 to
9c35d71
Compare
dmakarov
previously approved these changes
Nov 15, 2024
|
Leaving the PR open for time being, in case there are any other comments. |
buffalojoec
reviewed
Nov 18, 2024
pgarg66
force-pushed
the
remove-vote-dep
branch
from
9c35d71 to
d508d0a
Compare
dmakarov
previously approved these changes
Nov 18, 2024
LucasSte
reviewed
Nov 19, 2024
pgarg66
force-pushed
the
remove-vote-dep
branch
from
f21df42 to
42b2c7a
Compare
pgarg66
force-pushed
the
remove-vote-dep
branch
from
42b2c7a to
e5136ac
Compare
buffalojoec
reviewed
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
SVM code is currently dependent on
solana-votecrate. This dependency can be removed, that'll make it easier to move SVM to its own repo.Summary of Changes
The loader was using vote accounts HashMap to access stake for a given vote account. It didn't need any other information from the account. This change creates a HashMap of vote account pubkey and it's stake, and passes it to SVM. This helped remove the dependency on
solana-votecrate.Fixes #