-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
excludes deprecated values from pull responses #3653
excludes deprecated values from pull responses #3653
Conversation
b8cac7b
to
cdf7579
Compare
this PR stops propagating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I think we may run into a similar issue as we ran into here: #2637.
Nodes that are not upgraded to this code, will continuously send the deprecated types to the upgraded nodes via PullResponse
. I think it makes sense to stop propagating these deprecated types in PullResponse
s first and then once everyone has upgraded, we stop sending the deprecated types in push messages
We can actually stop sending |
cdf7579
to
4ad9386
Compare
done. |
4ad9386
to
a80c2ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Problem
Shouldn't waste bandwidth on propagating deperecated values.
Summary of Changes
The commit excludes deprecated values from pull responses.