Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

excludes deprecated values from pull responses #3653

Merged

Conversation

behzadnouri
Copy link

@behzadnouri behzadnouri commented Nov 14, 2024

Problem

Shouldn't waste bandwidth on propagating deperecated values.

Summary of Changes

The commit excludes deprecated values from pull responses.

@behzadnouri behzadnouri force-pushed the gossip-exclude-deprecated-values branch from b8cac7b to cdf7579 Compare November 15, 2024 14:21
@gregcusack
Copy link

this PR stops propagating NodeInstance (among other deprecated types), completing the next step outlined here: #2637

Copy link

@gregcusack gregcusack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I think we may run into a similar issue as we ran into here: #2637.
Nodes that are not upgraded to this code, will continuously send the deprecated types to the upgraded nodes via PullResponse. I think it makes sense to stop propagating these deprecated types in PullResponses first and then once everyone has upgraded, we stop sending the deprecated types in push messages

@gregcusack
Copy link

We can actually stop sending NodeInstances via push in this PR since #2637 stopped sending them in PullResponses

@behzadnouri behzadnouri force-pushed the gossip-exclude-deprecated-values branch from cdf7579 to 4ad9386 Compare November 20, 2024 14:54
@behzadnouri behzadnouri changed the title excludes deprecated values from push messages and pull responses excludes deprecated values from pull responses Nov 20, 2024
@behzadnouri
Copy link
Author

So I think we may run into a similar issue as we ran into here: #2637. Nodes that are not upgraded to this code, will continuously send the deprecated types to the upgraded nodes via PullResponse. I think it makes sense to stop propagating these deprecated types in PullResponses first and then once everyone has upgraded, we stop sending the deprecated types in push messages

done.

@behzadnouri behzadnouri force-pushed the gossip-exclude-deprecated-values branch from 4ad9386 to a80c2ea Compare November 20, 2024 14:57
Copy link

@gregcusack gregcusack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@behzadnouri behzadnouri merged commit cba5d47 into anza-xyz:master Nov 20, 2024
50 checks passed
@behzadnouri behzadnouri deleted the gossip-exclude-deprecated-values branch November 20, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants