Feature - disable account loader special case #3548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
Lichtso
added
the
automerge
2501babe
approved these changes
Nov 8, 2024
mergify bot
pushed a commit
that referenced
this pull request
Nov 8, 2024
Feature gate disable_account_loader_special_case. (cherry picked from commit f0d7e4f) # Conflicts: # sdk/feature-set/src/lib.rs
Lichtso
deleted the
feature/disable_account_loader_special_case_on_master
branch
Lichtso
added a commit
that referenced
this pull request
Nov 8, 2024
Feature gate disable_account_loader_special_case. (cherry picked from commit f0d7e4f)
Lichtso
added a commit
that referenced
this pull request
Nov 8, 2024
Feature gate disable_account_loader_special_case. (cherry picked from commit f0d7e4f)
Lichtso
added a commit
that referenced
this pull request
Nov 11, 2024
… (#3552) Feature - disable account loader special case (#3548) Feature gate disable_account_loader_special_case. (cherry picked from commit f0d7e4f) Co-authored-by: Alexander Meißner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This "optimization" actually costs us performance, see Discord discussion.
Summary of Changes
Adds a feature gate to remove the "optimization".
Feature Gate Issue: #3513