-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature cleanup: address lookup table program authority checks #3540
feature cleanup: address lookup table program authority checks #3540
Conversation
The Firedancer team maintains a line-for-line reimplementation of the |
@topointon-jump does cleaning up a feature in a builtin like this affect you guys? re: Mergify note. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning this up! I played around with cleaning up some more cli stuff and just committed that to your branch, hope you don't mind. Just figured it was faster than having you redo the same cleanup. Can you take a look and make sure it looks correct?
Yep, lgtm. Thanks for throwing that up! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@topointon-jump does cleaning up a feature in a builtin like this affect you guys? re: Mergify note.
@buffalojoec it does, thanks for the heads up!
c0edb2e
to
dec4542
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Problem
Feature
FKAcEvNgSY79RpqsPNUV5gDyumopH4cEHqUxyfm8b8Ap
(relax_authority_signer_check_for_lookup_table_creation
) has been activated on all clusters. It can be cleaned up.Summary of Changes
Clean up the feature in the builtin, tests, and CLI.