Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature cleanup: address lookup table program authority checks #3540

Merged

Conversation

buffalojoec
Copy link

Problem

Feature FKAcEvNgSY79RpqsPNUV5gDyumopH4cEHqUxyfm8b8Ap (relax_authority_signer_check_for_lookup_table_creation) has been activated on all clusters. It can be cleaned up.

Summary of Changes

Clean up the feature in the builtin, tests, and CLI.

@buffalojoec buffalojoec requested a review from jstarry November 8, 2024 10:42
Copy link

mergify bot commented Nov 8, 2024

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@buffalojoec
Copy link
Author

@topointon-jump does cleaning up a feature in a builtin like this affect you guys? re: Mergify note.

Copy link

@jstarry jstarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up! I played around with cleaning up some more cli stuff and just committed that to your branch, hope you don't mind. Just figured it was faster than having you redo the same cleanup. Can you take a look and make sure it looks correct?

@buffalojoec
Copy link
Author

Can you take a look and make sure it looks correct?

Yep, lgtm. Thanks for throwing that up!

Copy link

@topointon-jump topointon-jump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@topointon-jump does cleaning up a feature in a builtin like this affect you guys? re: Mergify note.

@buffalojoec it does, thanks for the heads up!

@buffalojoec buffalojoec force-pushed the alt-authority-check-feature-cleanup branch from c0edb2e to dec4542 Compare November 19, 2024 00:47
@buffalojoec buffalojoec requested a review from jstarry November 19, 2024 00:47
Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@buffalojoec buffalojoec merged commit 27a5ba8 into anza-xyz:master Nov 25, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants