Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RuntimeTransacton for TransactionView types #3529

Merged
merged 6 commits into from
Nov 8, 2024

Conversation

apfitzge
Copy link

@apfitzge apfitzge commented Nov 7, 2024

Problem

  • RuntimeTransaction is the entrypoint for our execution pipeline
  • Need TransactionView types to fit into this static -> dynamic RuntimeTransaction meta pipeline

Summary of Changes

  • separate is_simple_vote_transaction_impl
  • move RuntimeTransaction transition paths to separate files
    • thought here is that SDK types and TransactionView go through different, although similar, transition paths
    • Shared impl(s) in the top-level file
  • TransactionView::TransactionVersion separate file to be made public (not sure how clippy didn't yell about this before!)
  • Implement RuntimeTransaction instantiation for {Sanitized|Resolved}TransactionView types

Fixes #

@apfitzge apfitzge marked this pull request as ready for review November 7, 2024 20:35
@apfitzge apfitzge requested a review from tao-stones November 7, 2024 20:36
@apfitzge apfitzge changed the title move runtime-transaction chain into submodule RuntimeTransacton for TransactionView types Nov 7, 2024
Copy link

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@apfitzge apfitzge merged commit 21a027a into anza-xyz:master Nov 8, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants