Bank::new_from_fields() always gets the accounts lt hash from the snapshot #3519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While prototype testing feature activation of the accounts lt hash I found an issue when restarting from a snapshot.
If the snapshot was created with the accounts lt hash CLI arg ON, but loaded with the cli arg OFF, then the accounts verification at startup would fail.
This is because we copy the accounts lt hash from the snapshot based on the CLI arg, but verify the accounts based on the snapshot value. This is a mismatch in logic; both need to be the same.
Summary of Changes
In Bank::new_from_fields(), copy the accounts lt hash from the snapshot always (if present). This now matches the behavior used to verify the accounts at startup.