v2.1: Disallow --rocksdb-shred-compaction fifo in the validator (backport of #3451) #3464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
The use of fifo compaction in rocksdb is deprecated (as of v2.0). The current behavior emits a warning if fifo is set. This change removes "fifo" as an option, leaving "level" as the only valid value for --rocksdb-shred-compaction (cherry picked from commit fddc554)
|
I would like to BP this PR - I probably should have landed this PR prior to v2.1 getting cut, but the intention was always to remove this as an option in v2.1 as noted in the v2.0 section of the changelog: |
AshwinSekar
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fifo compaction in rocksdb (Blockstore) was deprecated in v2.0 (see #1882). Currently, a warning is emitted but use of
fifois still permitted.Summary of Changes
This change actually makes
fifoan invalid option for--rocksdb-shred-compaction, leavinglevelas the only valid option.The actual fifo code that is plumbed down several layers will be removed in a subsequent PR
Testing
Started a validator real quick and ensured that things errored out with
--rocksdb-shred-compaction fifoand that--rocksdb-shred-compaction levelOR not specifying that flag at all proceeded without issueThis is an automatic backport of pull request #3451 done by Mergify.