Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix violations of elided_named_lifetimes #3449

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

ksolana
Copy link

@ksolana ksolana commented Nov 3, 2024

Problem

rust-lang/rust#129207 helps name certain elided lifetimes so we can name them accordingly.

Summary of Changes

Add lifetime markers for those reported by the linter

Copy link

@bw-solana bw-solana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some conflicts that will need to be resolved, but this LGTM

@ksolana ksolana merged commit c15f89c into anza-xyz:master Nov 6, 2024
40 checks passed
@ksolana ksolana deleted the lifetime branch November 6, 2024 03:54
@behzadnouri
Copy link

@ksolana looks like you checked in file ledger/ledger.lock with this patch.

@ksolana
Copy link
Author

ksolana commented Nov 6, 2024

ah, sorry about that. putting a patch to remove that file.

@ksolana ksolana mentioned this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants