Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract offchain-message crate #3443

Merged
merged 8 commits into from
Dec 9, 2024
Merged

Extract offchain-message crate #3443

merged 8 commits into from
Dec 9, 2024

Conversation

kevinheavey
Copy link

@kevinheavey kevinheavey commented Nov 2, 2024 •
edited
Loading

Problem

solana_sdk::offchain_message imposes a solana_sdk dep on Solana CLI crates

Summary of Changes

  • Move to its own crate and re-export with deprecation
  • Put the verify method behind an optional feature like solana_signature does

This branches off #3087 so that needs to be merged first (update: done)

@kevinheavey kevinheavey marked this pull request as draft November 2, 2024 15:16
@kevinheavey kevinheavey force-pushed the extract-offchain-message branch 2 times, most recently from fff75e7 to 47a73fe Compare November 6, 2024 17:33
@kevinheavey kevinheavey marked this pull request as ready for review November 6, 2024 18:22
@kevinheavey kevinheavey mentioned this pull request Nov 14, 2024
Merged
@kevinheavey kevinheavey force-pushed the extract-offchain-message branch from 47a73fe to 7b0b77f Compare November 14, 2024 20:33
@kevinheavey kevinheavey force-pushed the extract-offchain-message branch 3 times, most recently from 7b82e88 to b8b7c5b Compare December 4, 2024 18:46
@kevinheavey kevinheavey force-pushed the extract-offchain-message branch from b8b7c5b to 03f5c70 Compare December 5, 2024 13:44
joncinque
joncinque reviewed Dec 6, 2024
View reviewed changes
Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the tiny bit about docs, then we can get this in. @yihau can you accept solana-offchain-message?

sdk/offchain-message/Cargo.toml Show resolved Hide resolved
sdk/offchain-message/src/lib.rs Outdated Show resolved Hide resolved
kevinheavey and others added 2 commits December 6, 2024 16:58
@yihau yihau merged commit de77e17 into anza-xyz:master Dec 9, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joncinque joncinque joncinque approved these changes

Assignees
No one assigned
Labels
need:merge-assist
Projects
SDK Breakup + Breakout
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinheavey @joncinque @yihau