New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor - program v4 CLI #3428

Merged

Lichtso merged 9 commits into anza-xyz:master from Lichtso:refactor/cli_program_v4

Nov 18, 2024

Lichtso commented Nov 1, 2024 •

edited

Loading

Problem

The program v4 CLI is missing some features which the program v3 CLI has.

Summary of Changes

New features:

Adds --use-rpc option for deployment.
Combines deploy and redeploy commands into one.
Adds optional upload range parameters --start-offset and --end-offset.
Enables partial deployments (so one can restart a failed deployment attempt).

General cleanup:

Removes ProgramV4CommandConfig wrapper. This allows us to have access to all the config fields, not just a subset of them.
Moves program_location parameter inside process_deploy_program().
Combines the underlying ProgramV4CliCommand as well.
Inlines build_create_buffer_message(), build_retract_and_truncate_messages() and build_retract_and_deploy_messages().
Fixes cargo registry.

Lichtso force-pushed the refactor/cli_program_v4 branch from 260c4db to edd644f Compare

November 1, 2024 19:22

Lichtso requested a review from pgarg66

November 1, 2024 19:25

Lichtso marked this pull request as ready for review

November 1, 2024 19:25

pgarg66 reviewed

View reviewed changes

cargo-registry/src/crate_handler.rs Show resolved Hide resolved

pgarg66 reviewed

View reviewed changes

cli/src/program_v4.rs Outdated Show resolved Hide resolved

pgarg66 reviewed

View reviewed changes

cli/src/program_v4.rs Show resolved Hide resolved

pgarg66 reviewed

View reviewed changes

cli/src/program_v4.rs Show resolved Hide resolved

pgarg66 reviewed

View reviewed changes

cli/src/program_v4.rs Show resolved Hide resolved

pgarg66 reviewed

View reviewed changes

cli/src/program_v4.rs Show resolved Hide resolved

pgarg66 reviewed

View reviewed changes

cli/src/program_v4.rs Outdated Show resolved Hide resolved

Lichtso force-pushed the refactor/cli_program_v4 branch from edd644f to 2d7347f Compare

November 4, 2024 22:46

Lichtso added 9 commits

November 11, 2024 09:57


          Removes ProgramV4CommandConfig wrapper.

e3de9e3


          Adds use_rpc option for deployment.

5c1a247


          Moves program_location parameter inside process_deploy_program().

6c5bfcf


          Combines deploy and redeploy commands into one.

c3a005d


          Combines the underlying ProgramV4CliCommand as well.

5f7a53f


          Adds optional upload range parameters.

104e588


          Inlines build_create_buffer_message(), build_retract_and_truncate_mes…

4c70c61

…sages() and build_retract_and_deploy_messages().


          Fixes cargo registry.

e040e17


          Make cargo clippy happy.

414704c

Lichtso force-pushed the refactor/cli_program_v4 branch from 2d7347f to 414704c Compare

November 11, 2024 10:01

pgarg66 approved these changes

View reviewed changes

Lichtso merged commit c2880bb into anza-xyz:master

40 checks passed

Lichtso deleted the refactor/cli_program_v4 branch

November 18, 2024 18:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet