Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runs accounts lt hash startup calculation in thread pool #3380

Merged

Conversation

brooksprumo
Copy link

@brooksprumo brooksprumo commented Oct 30, 2024

Problem

At startup, if calculating the accounts lt hash, we do not specify a thread pool to run in, so it will end up running in the global thread pool. This may not be ideal, if other tasks are running in the global pool (or get added later).

There is already a thread pool for Bank::new_from_fields(), so we should use that one here.

Summary of Changes

At startup, run the accounts lt hash calculation in the Bank::new_from_fields() thread pool.

@brooksprumo brooksprumo self-assigned this Oct 30, 2024
@brooksprumo brooksprumo marked this pull request as ready for review October 30, 2024 12:45
Copy link

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@brooksprumo brooksprumo merged commit d968309 into anza-xyz:master Oct 30, 2024
40 checks passed
@brooksprumo brooksprumo deleted the lthash/bank-new-fields-pool branch October 30, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants