Add skip preflight to CLI

[Woody4618]

Problem

CLI was missing the option to set skip-preflight option.
This is especially useful because some RPC providers are not using swqos when preflight is enabled.
This is speeding up program deployments by a lot using these RPC providers.

Summary of Changes

I added skip-preflight as global flag and changed all the places where transactions are sent to use that flag.
Some test had the skip preflight flag set to true, but it was not actually used. So these tests that were parsing the responses are adjusted to handle both cases.

Refactoring?

In an additional step if would maybe be nice to remove CommitmentConfig from the CliConfig and move it into the RpcSendTransactionConfig. But that looked like a bit of a bigger refactoring so I didnt include it.
Another option would also be moving RpcSendTransactionConfig directly into RpcClient to enable it everywhere. But that is an even bigger refactoring.

[joncinque]

Really good work overall, thanks for the contribution! Just a few things to fixup, then we can land this

[Woody4618]

Thank you very much for the review! Pushed the changes :)

[joncinque]

Just a couple of little nits, then we can get this in!

[joncinque]

Be sure to run ./cargo nightly fmt --all from the top of the repo, looks like there are some formatting issues. You can also run ./scripts/cargo-clippy-nightly.sh for any lint issues.

[Woody4618]

It looks like the linter does not want me to use deprecated functions. But since its the fallback. How can i not use them?

[joncinque]

It looks like the linter does not want me to use deprecated functions. But since its the fallback. How can i not use them?

You can add #[allow(deprecated)] for the deprecated functions

[Woody4618]

Can i Ignore this? when running ./scripts/cargo-clippy-nightly.sh

[joncinque]

Can i Ignore this? when running ./scripts/cargo-clippy-nightly.sh

You can always push your change and see if it passes CI, but it's better to run things locally. Are you missing a protobuf compiler on your machine?

[Woody4618]

I have it installed yes, via homebrew.
protoc --version
libprotoc 28.3
Looks like the linting worked though.

[joncinque]

Ah darn, sorry, I forgot to mention -- can you add an entry in the changelog for this feature? Under 2.2.0, how about something like:

  * Changes
    * CLI:
      * Add global `--skip-preflight` option for skipping preflight checks on all transactions sent through RPC. This flag, along with `--use-rpc`, can improve success rate with program deployments using the public RPC nodes.

[Woody4618]

Added the changelog entry

[joncinque]

Added the changelog entry

Might need a rebase -- there's a conflict

[mergify]

If this PR represents a change to the public RPC API:

1. Make sure it includes a complementary update to rpc-client/ (example)
2. Open a follow-up PR to update the JavaScript client @solana/web3.js (example)

Thank you for keeping the RPC clients in sync with the server API @Woody4618.

[mergify]

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

[joncinque]

@Woody4618 please double-check it, but this should be correct

[joncinque]

Thanks for your contribution!

[joncinque]

@febo can I get an approval here? I cleaned up the branch after a rebase, and it won't let me merge since I was the last pusher